Add a polling fallback to filesystem watcher #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the latest beta version of macOS broke the mechanism that we're using to observe filesystem change events. It's more than just filesystem observation that has broken: any attempt to run a hot-reloading workflow crashes the Figwheel process with an uncaught exception at startup. (Note that build-once still works, since it doesn't try to access filesystem events). The underlying hawk library does have an implementation of a less-efficient polling watcher. Figwheel can use this to provide hot-reloading even when native events aren't available. This commit wraps the `hawk.core/watch!` function to catch any exception that's thrown, and re-try with the same options *except* that it explicitly starts a polling watcher. See also - gjoseph/BarbaryWatchService#13 - java-native-access/jna#1216 Part of bhauman#253.
|
@bhauman what do you think: close this one, in favour of the |
|
Yeah let’s close it. Thanks!
Sent from ProtonMail Mobile
…On Tue, Jul 7, 2020 at 3:15 PM, Ryan McCuaig ***@***.***> wrote:
***@***.***(https://github.com/bhauman) what do you think: close this one, in favour of the {:hawk-options ,,,} fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#254 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAAUQA72ABROJV3CANXGCDR2OF5JANCNFSM4OSM3UAQ).
|
|
Closing without merge; everyone just use the |
|
FYI. This may or may not be relevant to you - I had a similar issue with another library that was also using hawk to monitor file changes. I was borrowing your code to see if that fixed it. While testing, I got a java.lang.UnsatisfiedLinkError. It's an Error and doesn't extend Exception. I had to catch an Error to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the latest beta version of macOS broke the mechanism that we're using to observe filesystem change events. It's more than just filesystem observation that has broken: any attempt to run a hot-reloading workflow crashes the Figwheel process with an uncaught exception at startup. (Note that build-once still works, since it doesn't try to access filesystem events).
The underlying hawk library does have an implementation of a less-efficient polling watcher. Figwheel can use this to provide hot-reloading even when native events aren't available.
This commit wraps the
hawk.core/watch!function to catch any exception that's thrown, and re-try with the same options except that it explicitly starts a polling watcher.See also
Part of #253.