Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Better bloom default settings #6546

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Better bloom default settings #6546

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebfed08
use 0.3 by default for intensity
mockersf Nov 10, 2022
76a028a
reduce mip levels
mockersf Nov 10, 2022
988b5da
avoid underflow
mockersf Nov 11, 2022
43d0d22
keep the default at 1.0
mockersf Nov 11, 2022
6eeb1a8
default to 0.3
mockersf Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/bevy_core_pipeline/src/bloom/mod.rs
View file
Open in desktop
Expand Up @@ -149,7 +149,7 @@ pub struct BloomSettings {
/// Scale used when upsampling (default: 1.0).
pub scale: f32,

/// Intensity of the bloom effect (default: 1.0).
/// Intensity of the bloom effect (default: 0.3).
pub intensity: f32,
}

Expand All @@ -159,7 +159,7 @@ impl Default for BloomSettings {
threshold: 1.0,
knee: 0.1,
scale: 1.0,
intensity: 1.0,
intensity: 0.3,
mockersf marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Expand Down Expand Up @@ -805,5 +805,5 @@ fn queue_bloom_bind_groups(
}

fn calculate_mip_count(min_view: u32) -> u32 {
((min_view as f32).log2().round() as u32 - 1).max(1)
((min_view as f32).log2().round() as i32 - 3).max(1) as u32
}