Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Ignore Timeout errors on Linux AMD & Intel #5957

Closed
wants to merge 6 commits into from

Commits on Nov 1, 2022

  1. Ignore Timeout errors on Linux AMD

    Alternative:
    
    An alternative solution found in the `wgpu` examples is:
    
    ```rust
    let frame = surface
        .get_current_texture()
        .or_else(|_| {
            render_device.configure_surface(surface, &swap_chain_descriptor);
            surface.get_current_texture()
        })
        .expect("Error reconfiguring surface");
    window.swap_chain_texture = Some(TextureView::from(frame));
    ```
    
    See: <https://github.com/gfx-rs/wgpu/blob/94ce76391b560a66e36df1300bd684321e57511a/wgpu/examples/framework.rs#L362-L370>
    
    The reason I went with this PR's solution is that `configure_surface`
    seems to be quite an expensive operation, and it would run every frame
    with the wgpu framework solution, despite the fact it works perfectly
    fine without `configure_surface`.
    
    I know this looks super hacky with the linux-specific line and the AMD
    check, but my understanding is that the `Timeout` occurence is specific
    to a quirk of some AMD drivers on linux, and if otherwise met should be
    considered a bug.
    nicopap committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f9ae8d7 View commit details
    Browse the repository at this point in the history
  2. Document quirky behavior

    nicopap committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    69572e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b3b454 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb04948 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Make error message a trace

    nicopap committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    587b33f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. improve variables

    cart committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    a988909 View commit details
    Browse the repository at this point in the history