[Merged by Bors] - Better bloom default settings

[mockersf]

Objective

• Use better defaults for bloom

Solution

• Divide the intensity by 3. It's still noticeable
• Change the mip level? (not sure about that change, it's from a discussion with @superdump)

bloom example

main:

this pr:

bistro scene

main:

this pr:

[superdump]

Reducing the maximum mip level is about limiting the minimum resolution that a mip can be to avoid what I think would be considered an aliasing artifact. If we go below the shortest edge being 8 pixels for the highest mip level then there are large scale artifacts where the bloom tracks with the camera.

Before:

IMG_0043.MOV

After:

IMG_0044.MOV

I guess it’s a bit like having too few local dimming zones on a monitor backlight.

[superdump]

@mockersf I’m not sure if -3 is enough so it would be good if it were configurable. As a human I don’t relate to mip levels directly, instead I think it could be good to have a setting for minimum shortest edge resolution in pixels for the maximum mip level and make the maths work for that. Default to 8 or 16.

[mockersf]

Default to 8 or 16.

    In Device::create_texture
      note: label = `bloom_texture_a`
    Texture descriptor mip level count 16 is invalid, maximum allowed is 11

This can cause crashes if the user can specify any number they want.

I think I would prefer to stick with this -3 for now, and think about adding a setting for it after the release

[superdump]

Default to 8 or 16.

    In Device::create_texture
      note: label = `bloom_texture_a`
    Texture descriptor mip level count 16 is invalid, maximum allowed is 11

This can cause crashes if the user can specify any number they want.

I think I would prefer to stick with this -3 for now, and think about adding a setting for it after the release

What change did you do to get that? I’ll come up with some maths in a bit. :)

[JMS55]

I’m not sure if -3 is enough so it would be good if it were configurable. As a human I don’t relate to mip levels directly, instead I think it could be good to have a setting for minimum shortest edge resolution in pixels for the maximum mip level and make the maths work for that. Default to 8 or 16.

Imo we should leave it as -3, and see if it's actually a problem that anyone brings up before preemptively adding a setting. That way we can also get feedback on whether -3 is a good default or not, and what would be better.

I also think keeping it in terms of mip levels is better, because it makes more sense for users to adjust a number +/- 1 until it looks correct, than changing between 2/4/8/16/32 etc.

[cart]

bors r+

[cart]

(Feel free to continue discussing the merits of configuring -3, but I think this is sufficient for 0.9 / the changes here are necessary)

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-and-install-on-iOS
• build-android
• build (macos-latest)
• build (ubuntu-latest)
• build-wasm
• build (windows-latest)
• build-without-default-features (bevy)
• build-without-default-features (bevy_ecs)
• build-without-default-features (bevy_reflect)
• check-compiles
• check-doc
• check-missing-examples-in-docs
• ci
• markdownlint
• run-examples
• run-examples-on-wasm
• run-examples-on-windows-dx12