amd gpu make shadows are misplaced on a very large plane

[hymm]

Bevy version

0.8, main 9b56b54 (Nov 10, 2022)

Relevant system information

Windows 11
AdapterInfo { name: "AMD Radeon RX 6600", vendor: 4098, device: 29695, device_type: DiscreteGpu, driver: "AMD proprietary driver", driver_info: "22.9.2", backend: Vulkan }

What you did

Ran cargo run --release --example many_foxes and resized the window by grabbing the bottom right with the mouse.

What went wrong

Shadows on the foxes are misplaced sometimes.

[superdump]

Could you test with this: #6543 ? I don't think it will affect this one but maybe...

[mockersf]

this seems to be due to #6384

[superdump]

this seems to be due to #6384

Ah... I think it was weird stuff like this which was why I didn't use the light's translation and commented as such. And when I made an attempt to achieve the same kind of thing, I instead adjusted the left/right/top/bottom/near/far.

[irate-devil]

I can't reproduce this on Manjaro with a 2070 SUPER.

this seems to be due to #6384

Looking at the code, I wouldn't expect that behavior to change on different hardware, but it would be great if people could test that.
Otherwise, a git disect would be smart

[greytdepression]

I can't reproduce it either on Fedora with an Intel integrated GPU

[JMS55]

Can't reproduce. Both after the latest commit c4e791d, or going back ~5 commits.

Windows 11
AdapterInfo { name: "NVIDIA GeForce RTX 3080", vendor: 4318, device: 8710, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "526.47", backend: Vulkan }

[haike0513]

It can be reproduce in my computer, It's seems about AMD GPU

Windows 11
AdapterInfo { name: "AMD Radeon(TM) Graphics", vendor: 4098, device: 5761, device_type: IntegratedGpu, driver: "AMD proprietary driver", driver_info: "22.20.28", backend: Vulkan }

[Indy2222]

My observations:

• It happens already in commit 76829f9
• c3c4088 is still affected
• The shadows are off immediately after the example window is opened
• It seems the the window size has to be "just right" for it to work properly
• My system: bevy_render::renderer: AdapterInfo { name: "AMD Radeon RX 6700 XT (RADV NAVI22)", vendor: 4098, device: 29663, device_type: DiscreteGpu, backend: Vulkan } and Arch Linux

[Elabajaba]

this seems to be due to #6384

Tried the commit before that one was merged, still broken.

[Elabajaba]

After a bunch of back and forth on discord, this seems to be some sort of rounding or floating point precision issue with the absolutely massive plane that the many_foxes example uses.

@robtfm reproduced the issues on a 3070 with a 500000000 sized plane, while the current 500000 plane causes issues on AMD GPUs.

Changing it to a 5000 sized plane seems to fix it.

[hymm]

fixed in above pr

[hymm]

reopening issue as we should triage why nvidia and amd are different.