Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 fixes #133

Merged
merged 4 commits into from
Mar 30, 2019
Merged

Python 3.8 fixes #133

merged 4 commits into from
Mar 30, 2019

Conversation

Kodiologist
Copy link
Contributor

No description provided.

@Kodiologist
Copy link
Contributor Author

I'm not sure what to make of the test failures on Travis. nosetests --nocapture passes on my own machine (running Ubuntu 18.10) with Python 3.8.0a2.

@berkerpeksag
Copy link
Owner

I guess the cause of the failure is that something has changed in the development version of Python. Also, our Travis configuration seems wrong, because the following lines were supposed to make the build for 3.8-dev passed in case of a failure:

astor/.travis.yml

Lines 20 to 21 in 6413903

allow_failures:
- python: 3.8-dev

@Kodiologist
Copy link
Contributor Author

I removed those lines in this PR, because I expected the build to pass. And I think I'm using the same version of Python 3.8.

@Kodiologist Kodiologist changed the title Fix code generation with attributes of integer literals Python 3.8 fixes Mar 30, 2019
@Kodiologist
Copy link
Contributor Author

@berkerpeksag Okay, all should be good now.

Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great patch, just a very minor comment on reST markup. Thank you very much!

By the way, feel free to submit a separate PR (or use this one if you prefer) to add Python 3.8 to trove classifiers and update other places (I can't remember if there's more places we need to update :))

* Fixed code generation with ``u``-prefixed string literals.
(Fixed by Kodi Arfer in `PR 133`_.)

.. _`PR 133`: https://github.com/berkerpeksag/astor/pull/133
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can reuse the first one here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@berkerpeksag
Copy link
Owner

Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated.

@Kodiologist
Copy link
Contributor Author

feel free to submit a separate PR (or use this one if you prefer) to add Python 3.8 to trove classifiers and update other places (I can't remember if there's more places we need to update :))

I've updated the trove classifiers, but I can't remember anything else that needs to be changed, either.

Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated.

It's more your project than mine, but my philosophy has always been that it's easier to read history in bite-sized chunks.

@berkerpeksag berkerpeksag merged commit ea0dec3 into berkerpeksag:master Mar 30, 2019
@berkerpeksag
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants