-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.8 fixes #133
Python 3.8 fixes #133
Conversation
I'm not sure what to make of the test failures on Travis. |
I guess the cause of the failure is that something has changed in the development version of Python. Also, our Travis configuration seems wrong, because the following lines were supposed to make the build for 3.8-dev passed in case of a failure: Lines 20 to 21 in 6413903
|
I removed those lines in this PR, because I expected the build to pass. And I think I'm using the same version of Python 3.8. |
@berkerpeksag Okay, all should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great patch, just a very minor comment on reST markup. Thank you very much!
By the way, feel free to submit a separate PR (or use this one if you prefer) to add Python 3.8 to trove classifiers and update other places (I can't remember if there's more places we need to update :))
* Fixed code generation with ``u``-prefixed string literals. | ||
(Fixed by Kodi Arfer in `PR 133`_.) | ||
|
||
.. _`PR 133`: https://github.com/berkerpeksag/astor/pull/133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can reuse the first one here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated. |
I've updated the trove classifiers, but I can't remember anything else that needs to be changed, either.
It's more your project than mine, but my philosophy has always been that it's easier to read history in bite-sized chunks. |
Thank you! |
No description provided.