Add assignment expressions #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodiologist
force-pushed
the
assignment-expr
branch
from
a804212
to
62c3714
Compare
|
Okay, I've rebased this one, too. |
berkerpeksag
reviewed
Apr 2, 2019
There was a problem hiding this comment.
I'm fine with a quick-and-dirty solution. However, it would be great if we could add more tests. We could borrow from the PEP and its implementation. We could even borrow the ones that we can't cover yet with the initial implementation and mark them as expectedFailure.
Also, please add a release note to docs/changelog.rst.
Thank you!
Kodiologist
force-pushed
the
assignment-expr
branch
from
62c3714
to
4aa192f
Compare
|
I've added more tests from the PEP. I've also used |
berkerpeksag
approved these changes
Apr 6, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick-'n'-dirty attempt at #126. (Closes #126.)