Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add upper bound for packaging version #3331

Merged
merged 2 commits into from Dec 8, 2022
Merged

fix: add upper bound for packaging version #3331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9ced6
fix: failing ci
aarnphm Dec 8, 2022
b516dab
chore: lazy import requirementsfile
aarnphm Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@ dependencies = [
"opentelemetry-instrumentation-asgi==0.35b0",
"opentelemetry-semantic-conventions==0.35b0",
"opentelemetry-util-http==0.35b0",
"packaging>=20.0",
"packaging>=20.0,<22",
"pathspec",
"pip-tools>=6.6.2",
"pip-requirements-parser>=31.2.0",
Expand Down
3 changes: 2 additions & 1 deletion src/bentoml/_internal/bento/build_config.py
View file
Open in desktop
Expand Up @@ -16,7 +16,6 @@
import psutil
import fs.copy
from pathspec import PathSpec
from pip_requirements_parser import RequirementsFile

from ..utils import bentoml_cattr
from ..utils import resolve_user_filepath
Expand Down Expand Up @@ -598,6 +597,8 @@ def write_to_bento(self, bento_fs: FS, build_ctx: str) -> None:
f.write(install_sh)

if self.requirements_txt is not None:
from pip_requirements_parser import RequirementsFile

requirements_txt = RequirementsFile.from_file(
resolve_user_filepath(self.requirements_txt, build_ctx),
include_nested=True,
Expand Down