Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add upper bound for packaging version #3331

Merged
merged 2 commits into from Dec 8, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Dec 8, 2022

packaging 22.0 removes LegacyVersion, which pip-requirements-parser are currently using

@aarnphm aarnphm requested a review from a team as a code owner December 8, 2022 04:13
@aarnphm aarnphm requested review from larme and removed request for a team December 8, 2022 04:13
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3331 (b516dab) into main (2f5e247) will increase coverage by 1.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3331      +/-   ##
==========================================
+ Coverage   31.33%   32.91%   +1.58%     
==========================================
  Files         109      109              
  Lines        9908     9918      +10     
  Branches     1628     1710      +82     
==========================================
+ Hits         3105     3265     +160     
+ Misses       6609     6424     -185     
- Partials      194      229      +35     
Impacted Files Coverage Δ
src/bentoml/_internal/bento/build_config.py 55.14% <100.00%> (+4.48%) ⬆️
src/bentoml/_internal/service/loader.py 39.13% <0.00%> (-0.29%) ⬇️
src/bentoml/_internal/resource.py 26.41% <0.00%> (ø)
src/bentoml/_internal/models/model.py 75.00% <0.00%> (ø)
src/bentoml/_internal/runner/utils.py 0.00% <0.00%> (ø)
src/bentoml/_internal/monitoring/otlp.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/grpc_app.py 0.00% <0.00%> (ø)
src/bentoml/_internal/utils/benchmark.py 0.00% <0.00%> (ø)
src/bentoml/_internal/utils/telemetry.py 0.00% <0.00%> (ø)
src/bentoml/_internal/marshal/dispatcher.py 0.00% <0.00%> (ø)
... and 15 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm changed the title fix: packaging CI deprecation fix: packaging upper lock Dec 8, 2022
@sauyon sauyon changed the title fix: packaging upper lock fix: add upper bound for packaging version Dec 8, 2022
@sauyon sauyon enabled auto-merge (squash) December 8, 2022 04:44
@sauyon sauyon merged commit b9b86fd into bentoml:main Dec 8, 2022
@aarnphm aarnphm deleted the chore/limit-packaging branch December 8, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants