Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log runner errors explicitly #2952

Merged
merged 2 commits into from Aug 30, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 25 additions & 11 deletions bentoml/_internal/server/runner_app.py
Expand Up @@ -213,16 +213,30 @@ async def _run(request: Request) -> Response:
params = pickle.loads(await request.body())

params = params.map(AutoContainer.from_payload)
ret = await runner_method.async_run(*params.args, **params.kwargs)

payload = AutoContainer.to_payload(ret, 0)
return Response(
payload.data,
headers={
PAYLOAD_META_HEADER: json.dumps(payload.meta),
"Content-Type": f"application/vnd.bentoml.{payload.container}",
"Server": f"BentoML-Runner/{self.runner.name}/{runner_method.name}/{self.worker_index}",
},
)

try:
ret = await runner_method.async_run(*params.args, **params.kwargs)
except BaseException as exc:
logger.error(
f"Exception on runner '{runner_method.runner.name}' method '{runner_method.name}'",
exc_info=exc,
)
return Response(
status_code=500,
headers={
"Content-Type": "text/plain",
"Server": f"BentoML-Runner/{self.runner.name}/{runner_method.name}/{self.worker_index}",
},
)
else:
payload = AutoContainer.to_payload(ret, 0)
return Response(
payload.data,
headers={
PAYLOAD_META_HEADER: json.dumps(payload.meta),
"Content-Type": f"application/vnd.bentoml.{payload.container}",
"Server": f"BentoML-Runner/{self.runner.name}/{runner_method.name}/{self.worker_index}",
},
)

return _run