fix: log runner errors explicitly #2952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Catch and log errors raised inside runners explicitly. If not logged explicitly, Uvicorn will log the error but we will lose the trace context causing the exception log to contain no trace and span IDs.
With this fix, errors will be explicitly logged in
runner_app
and an HTTP 500 response will be explicitly returned. Returning the HTTP 500 error by BentoML is ideal because Uvicorn will otherwise close the underlying connection withconnection: close
header, see https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/http/h11_impl.py#L436. Returning HTTP 500 response ourselves will preserve the connection for re-use. See new error message below.Thanks for reporting the error, @jiewpeng.
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.
Who can help review?
Feel free to tag members/contributors who can help review your PR.