Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: temp fix for models test #2949

Merged
merged 1 commit into from Aug 31, 2022
Merged

ci: temp fix for models test #2949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/unit/test_models.py
View file
Open in desktop
@@ -1,4 +1,5 @@
import os
import time
import random
import string
from sys import version_info as pyver
Expand Down Expand Up @@ -49,6 +50,8 @@ def test_models(tmpdir: "Path"):
) as testmodel:
testmodel1tag = testmodel.tag

time.sleep(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can check whether this is running in actions

Suggested change
time.sleep(1)
if os.getenv("GITHUB_ACTIONS"):
...

So that when test run locally we don't have to sleep it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address address @aarnphm's suggestion in a following PR if needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't special case our tests too much, it'll just make debugging harder.

Though I should probably debug what's going on here at some point...


with bentoml.models.create(
"testmodel",
module=__name__,
Expand Down