ci: temp fix for models test #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2949 +/- ##
=======================================
Coverage 70.62% 70.62%
=======================================
Files 104 104
Lines 9534 9534
=======================================
Hits 6733 6733
Misses 2801 2801 |
aarnphm
reviewed
Aug 29, 2022
| @@ -49,6 +50,8 @@ def test_models(tmpdir: "Path"): | |||
| ) as testmodel: | |||
| testmodel1tag = testmodel.tag | |||
|
|
|||
| time.sleep(1) | |||
There was a problem hiding this comment.
maybe we can check whether this is running in actions
Suggested change
| time.sleep(1) | |
| if os.getenv("GITHUB_ACTIONS"): | |
| ... |
So that when test run locally we don't have to sleep it
There was a problem hiding this comment.
Please address address @aarnphm's suggestion in a following PR if needed
There was a problem hiding this comment.
I think we shouldn't special case our tests too much, it'll just make debugging harder.
Though I should probably debug what's going on here at some point...
ssheng
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another temporary fix for the weird store issue that seems to occur only on actions.