Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return effective_url as string (without port details) #869

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Return effective_url as string (without port details) #869

wants to merge 4 commits into from

Conversation

tbrammar
Copy link

@tbrammar tbrammar commented Jan 7, 2020

This is an attempted fix for this issue #552

@tbrammar tbrammar mentioned this pull request Jan 7, 2020
Open
@bblimke
Copy link
Owner

bblimke commented Jan 7, 2020

Thank you @tbrammar. Looks good but I believe only the default port should be omitted?

@tbrammar
Copy link
Author

tbrammar commented Jan 7, 2020

@bblimke good catch 👍 - have updated to only remove standard ports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbrammar @bblimke