Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typhoeus::Response#effective_url should be a string, Addressable::URI returned #552

Open
erwanlr opened this issue Dec 11, 2015 · 2 comments

Comments

@erwanlr
Copy link

erwanlr commented Dec 11, 2015

Related to #540

As mentioned in the Typhoeus' doc, the effective_url method should return a string: https://github.com/typhoeus/typhoeus/blob/de61860fecec32b58e150e63219d1a4062a77855/lib/typhoeus/response/informations.rb#L181

Currently in webmock, an Addressable::URI object is returned

The fix would be to replace

:effective_url => request_signature.uri
by :effective_url => request_signature.uri.to_s

@erwanlr
Copy link
Author

erwanlr commented Dec 11, 2015

Furthermore, the default port (either 80 or 443 depending on the http/s used) is returned, which screw up specs a bit :/

@tbrammar
Copy link

tbrammar commented Jan 7, 2020

Implemented a simple PR here to fix this: #869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants