Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpclient_adapter: use uri after filters when building request signature #1050

Merged
merged 2 commits into from
Feb 19, 2024
Merged

httpclient_adapter: use uri after filters when building request signature #1050

merged 2 commits into from
Feb 19, 2024

Commits on Feb 13, 2024

  1. httpclient_adapter: use uri after filters when building req signature 

    If a filter changes the URI (e.g. to enforce a protocol or change the
hostname of the request) this is currently unable to be mocked as
webmock fetches the URI for the signature of the request before calling
the filters!
    @mattbnz
    mattbnz committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    65ba375 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. httpclient: include a uri modifying filter in spec tests.

    @mattbnz
    mattbnz committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    96726c0 View commit details
    Browse the repository at this point in the history