httpclient_adapter: use uri after filters when building request signature #1050
Conversation
If a filter changes the URI (e.g. to enforce a protocol or change the hostname of the request) this is currently unable to be mocked as webmock fetches the URI for the signature of the request before calling the filters!
|
@mattbnz thank you for submitting the PR. you are correct that one expects the signature to be based on the final url, after all filters applied. Would you care to add at least one test to https://github.com/bblimke/webmock/blob/master/spec/acceptance/httpclient/httpclient_spec.rb to verify that the behaviour works as expected? |
|
@bblimke thank you for the great library and quick response! I'm pretty new to ruby and rspec so any guidance on the desired test style is welcome - for now I just modified the expectations of the existing tests to include URI modification in the filter - seemed to me straightforward enough and simple enough in concept to the existing tests that it made sense vs creating a new spec/test overall... but if you prefer a completely separate test let me know. Verified that the changed spec fails on master and passes in this branch. Cheers |
|
@mattbnz thank you. I believe the provided extension of existing spec is sufficient 👍 |
If a filter changes the URI (e.g. to enforce a protocol or change the hostname of the request) this is currently unable to be mocked as webmock fetches the URI for the signature of the request before calling the filters!