Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update balena-request to v11.4.2 #1126

Merged
1 commit merged into from Sep 21, 2021
Merged

Conversation

klutchell
Copy link
Contributor

Update balena-request from 11.4.1 to 11.4.2

Change-type: patch
Signed-off-by: Kyle Harding kyle@balena.io


Contributor checklist
  • Includes tests
  • Includes typings
  • Includes updated documentation
  • Includes updated build output

Update balena-request from 11.4.1 to 11.4.2

Change-type: patch
Signed-off-by: Kyle Harding <kyle@balena.io>
@klutchell
Copy link
Contributor Author

@balena-ci I self-certify!

@klutchell
Copy link
Contributor Author

@balena-ci retest

@thgreasi
Copy link
Member

@klutchell I restarted the tests from appveyor (balena-ci retest doesn't do that).

FAILED TESTS:
  Logs
    given a device
      balena.logs.history()
        ✖ should successfully load historical logs
          HeadlessChrome 79.0.3945 (Windows 8.1.0.0)
        O: Request error: The API cannot handle your request right now
            at Object.<anonymous> (es2015/balena-browser.min.js:1:121658)
            at Generator.next (<anonymous>)
            at n (es2015/balena-browser.min.js:1:503680)

Looks like it's related to what was reported at:
See: https://www.flowdock.com/app/rulemotion/resin-devops/threads/vRYzOsq21lcYUHQFIX42_x1DxQc

@klutchell
Copy link
Contributor Author

Looks like it's related to what was reported at

@thgreasi thanks, that's what I suspected as well with the API timeouts

@thgreasi
Copy link
Member

The node tests atm fail b/c of
See: node-fetch/node-fetch#1300

@LinusU
Copy link

LinusU commented Sep 21, 2021

The node-fetch bug was fixed in 2.6.4, sorry for any inconvenience!

@klutchell
Copy link
Contributor Author

klutchell commented Sep 21, 2021

@thgreasi I think we are getting node-fetch from here: https://www.npmjs.com/package/fetch-ponyfill?activeTab=explore

How do we normally bump a dependency independently of an upstream that requires it? Just require the specified version of node-fetch in balena-request directly?

@LinusU
Copy link

LinusU commented Sep 21, 2021

Since you don't have a package lock file I think that you can just rerun the jobs and they should pick up the new version 🚀

@thgreasi
Copy link
Member

Thanks for the new release heads-up @LinusU. I'm honored 🙏

@ghost ghost merged commit cbd45fd into master Sep 21, 2021
@ghost ghost deleted the klutchell/balena-request-11-4-2 branch September 21, 2021 17:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants