os download: Avoid incomplete os downloads appearing as successful #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By forcing the zlib flush mode to Z_NO_FLUSH we are more likely to see an error on image download pipelines vs silent failure and incomplete files. This is part of a larger investigation and may be removed in the future when the root cause of the pipeline failures are identified. Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By forcing the zlib flush mode to Z_NO_FLUSH we are more likely to
see an error on image download pipelines vs silent failure and
incomplete files.
This is part of a larger investigation and may be removed in the
future when the root cause of the pipeline failures are identified.
Change-type: patch
Signed-off-by: Kyle Harding kyle@balena.io
Requires: balena-io-modules/balena-request#158 (merged in
balena-request@11.4.2)Requires: balena-io/balena-sdk#1126 (merged in
balena-sdk@15.51.1)See: #2346 (comment)
See: #2152