-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial WIP for procbots. #5
Merged
Merged
Commits on Jan 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for e947d0a - Browse repository at this point
Copy the full SHA e947d0aView commit details
Commits on Jan 31, 2017
-
Modify code after initial peer review.
* Separate interfaces into separate declaration files * Move Worker class into own source file * Use callback method to remove Worker from context map in child, rather than Worker class itself (cleaner) * Correct pointer to declaration files in package.json (now correctly points to `build`) * Add `tslint` gulp task, to ensure code is linted, add custom `tslint.json` that expands upon the default rules * Refactor code after initial linting * Include typings for a few libraries that were not typed * Add 'copydecs' task to copy explicit declaration files to `build` directory for interfaces * Github API is now imported as correct types * Untyped methods are now explicitly Promisified with a function type * Correct initRepo package.json * Ensure all libraries adhere to `tslint `import rules * Remove unused imports and variables * Add checks for unused variables and expressions to `tsconfig.json` * Correct callback for setTimeout in GithubBot * Split up unwieldy methods in VersionBot * Remove unused parentMap structure in Worker * Correct some typos
Configuration menu - View commit details
-
Copy full SHA for ab352f4 - Browse repository at this point
Copy the full SHA ab352f4View commit details -
Ensure ProcBot type has constructor that is passed an optional name, …
…instead of setting it in each derived child. Also remove implicitly typed variable.
Configuration menu - View commit details
-
Copy full SHA for 476dcf8 - Browse repository at this point
Copy the full SHA 476dcf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19dc480 - Browse repository at this point
Copy the full SHA 19dc480View commit details
Commits on Feb 2, 2017
-
Modify code based on ongoing TS standards work.
* Update `gulpfile.js` to remove now unrequired sourcemap option * Add `typings` directory, add typing for used `temp` functionality and include the `typings` directory in the `tsconfig.json` * Update spacing correctly in files * Ensure Promisified `temp` requirements use the typings by importing the `temp` module as normal
Configuration menu - View commit details
-
Copy full SHA for a6cff65 - Browse repository at this point
Copy the full SHA a6cff65View commit details -
* Modify `tsconfig.json` to specifically `include` correct typings and source * Ensure `gulpfile.js` uses specified files from `tsconfig.json` * Update `tslint.json`
Configuration menu - View commit details
-
Copy full SHA for 486fe15 - Browse repository at this point
Copy the full SHA 486fe15View commit details -
Configuration menu - View commit details
-
Copy full SHA for e01f46e - Browse repository at this point
Copy the full SHA e01f46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc63655 - Browse repository at this point
Copy the full SHA bc63655View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.