Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial WIP for procbots. #5

Merged
merged 8 commits into from
Feb 2, 2017
Merged

Initial WIP for procbots. #5

merged 8 commits into from
Feb 2, 2017

Commits on Jan 27, 2017

  1. Initial WIP for procbots.

    See README.md for details.
    hedss committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    e947d0a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2017

  1. Modify code after initial peer review.

    * Separate interfaces into separate declaration files
    * Move Worker class into own source file
    * Use callback method to remove Worker from context map in child, rather than Worker class itself (cleaner)
    * Correct pointer to declaration files in package.json (now correctly points to `build`)
    * Add `tslint` gulp task, to ensure code is linted, add custom `tslint.json` that expands upon the default rules
    * Refactor code after initial linting
    * Include typings for a few libraries that were not typed
    * Add 'copydecs' task to copy explicit declaration files to `build` directory for interfaces
    * Github API is now imported as correct types
    * Untyped methods are now explicitly Promisified with a function type
    * Correct initRepo package.json
    * Ensure all libraries adhere to `tslint `import rules
    * Remove unused imports and variables
    * Add checks for unused variables and expressions to `tsconfig.json`
    * Correct callback for setTimeout in GithubBot
    * Split up unwieldy methods in VersionBot
    * Remove unused parentMap structure in Worker
    * Correct some typos
    hedss committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    ab352f4 View commit details
    Browse the repository at this point in the history
  2. Ensure ProcBot type has constructor that is passed an optional name, …

    …instead of setting it in each derived child.
    
    Also remove implicitly typed variable.
    hedss committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    476dcf8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    19dc480 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2017

  1. Modify code based on ongoing TS standards work.

    * Update `gulpfile.js` to remove now unrequired sourcemap option
    * Add `typings` directory, add typing for used `temp` functionality and include the `typings` directory in the `tsconfig.json`
    * Update spacing correctly in files
    * Ensure Promisified `temp` requirements use the typings by importing the `temp` module as normal
    hedss committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    a6cff65 View commit details
    Browse the repository at this point in the history
  2. Update post-review.

    * Modify `tsconfig.json` to specifically `include` correct typings and source
    * Ensure `gulpfile.js` uses specified files from `tsconfig.json`
    * Update `tslint.json`
    hedss committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    486fe15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e01f46e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bc63655 View commit details
    Browse the repository at this point in the history