Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Joi #3505

Merged
merged 8 commits into from
Jun 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/base-service/base-json.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { expect } = require('chai')
const sinon = require('sinon')
const BaseJsonService = require('./base-json')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/base-svg-scraping.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const { expect } = require('chai')
const sinon = require('sinon')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const makeBadge = require('../../gh-badges/lib/make-badge')
const BaseSvgScrapingService = require('./base-svg-scraping')

Expand Down
2 changes: 1 addition & 1 deletion core/base-service/base-xml.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { expect } = require('chai')
const sinon = require('sinon')
const BaseXmlService = require('./base-xml')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/base-yaml.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { expect } = require('chai')
const sinon = require('sinon')
const BaseYamlService = require('./base-yaml')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const decamelize = require('decamelize')
// See available emoji at http://emoji.muan.co/
const emojic = require('emojic')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const { assertValidCategory } = require('./categories')
const checkErrorResponse = require('./check-error-response')
const coalesceBadge = require('./coalesce-badge')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/base.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { expect } = require('chai')
const sinon = require('sinon')
const trace = require('./trace')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/cache-headers.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const assert = require('assert')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const coalesce = require('./coalesce')

const serverStartTimeGMTString = new Date().toGMTString()
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/categories.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const categories = require('../../services/categories')

const isRealCategory = Joi.equal(categories.map(({ id }) => id)).required()
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/deprecated-service.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const camelcase = require('camelcase')
const BaseService = require('./base')
const { isValidCategory } = require('./categories')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/examples.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const pathToRegexp = require('path-to-regexp')
const coalesceBadge = require('./coalesce-badge')
const { makeFullUrl } = require('./route')
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/redirector.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const camelcase = require('camelcase')
const emojic = require('emojic')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const queryString = require('query-string')
const BaseService = require('./base')
const {
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/route.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const pathToRegexp = require('path-to-regexp')

function makeFullUrl(base, partialUrl) {
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/route.spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const { expect } = require('chai')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const { test, given, forCases } = require('sazerac')
const {
prepareRoute,
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/service-definitions.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')

// This should be kept in sync with the schema in
// `frontend/lib/service-definitions/service-definition-prop-types.js`.
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/validate.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const emojic = require('emojic')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const trace = require('./trace')

function validate(
Expand Down
2 changes: 1 addition & 1 deletion core/base-service/validate.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { expect } = require('chai')
const sinon = require('sinon')
const trace = require('./trace')
Expand Down
2 changes: 1 addition & 1 deletion core/server/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const fs = require('fs')
const path = require('path')
const url = require('url')
const bytes = require('bytes')
const Joi = require('joi')
const Joi = require('@hapi/joi')
const Camp = require('camp')
const makeBadge = require('../../gh-badges/lib/make-badge')
const GithubConstellation = require('../../services/github/github-constellation')
Expand Down
2 changes: 1 addition & 1 deletion core/service-test-runner/icedfrisby-shields.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { expect } = require('chai')

// based on https://github.com/paulmelnikow/icedfrisby-nock/blob/master/icedfrisby-nock.js
Expand Down
2 changes: 1 addition & 1 deletion doc/TUTORIAL.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ const { renderVersionBadge } = require('..//version')
const { BaseJsonService } = require('..')

// (4)
const Joi = require('joi')
const Joi = require('@hapi/joi')
const schema = Joi.object({
version: Joi.string().required(),
}).required()
Expand Down
4 changes: 2 additions & 2 deletions doc/rewriting-services.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ Once the route is working, fill out `render()` and `handle()`.
<details>

```js
const Joi = require('joi')
const Joi = require('@hapi/joi')
const { errorMessagesFor } = require('./github-helpers')

const issueSchema = Joi.object({
Expand Down Expand Up @@ -181,7 +181,7 @@ or create an abstract superclass like **PypiBase**:
<details>

```js
const Joi = require('joi')
const Joi = require('@hapi/joi')
const BaseJsonService = require('../base-json')

const schema = Joi.object({
Expand Down
2 changes: 1 addition & 1 deletion lib/logos.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { toSvgColor } = require('../gh-badges/lib/color')
const coalesce = require('../core/base-service/coalesce')
const { svg2base64 } = require('./svg-helpers')
Expand Down
75 changes: 59 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"fsos": "^1.1.3",
"gh-badges": "file:gh-badges",
"glob": "^7.1.4",
"joi": "14.3.1",
"joi-extension-semver": "2.0.0",
"@hapi/joi": "^15.0.3",
"joi-extension-semver": "3.0.0",
"js-yaml": "^3.13.1",
"jsonpath": "~1.0.1",
"lodash.countby": "^4.6.0",
Expand Down Expand Up @@ -192,7 +192,7 @@
"got": "^9.6.0",
"humanize-string": "^2.1.0",
"husky": "^2.3.0",
"icedfrisby": "2.0.0-alpha.5",
"icedfrisby": "2.0.0",
"icedfrisby-nock": "^1.1.0",
"is-png": "^2.0.0",
"is-svg": "^4.1.0",
Expand Down
2 changes: 1 addition & 1 deletion services/amo/amo-base.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { BaseJsonService } = require('..')
const { nonNegativeInteger } = require('../validators')

Expand Down
2 changes: 1 addition & 1 deletion services/amo/amo-rating.tester.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { isStarRating } = require('../test-validators')
const t = (module.exports = require('../tester').createServiceTester())

Expand Down
2 changes: 1 addition & 1 deletion services/ansible/ansible-quality.service.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { floorCount } = require('../color-formatters')
const { BaseJsonService, InvalidResponse } = require('..')

Expand Down
2 changes: 1 addition & 1 deletion services/ansible/ansible-role.service.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Joi = require('joi')
const Joi = require('@hapi/joi')
const { downloadCount } = require('../color-formatters')
const { metric } = require('../text-formatters')
const { BaseJsonService } = require('..')
Expand Down