Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Joi #3505

Merged
merged 8 commits into from Jun 2, 2019
Merged

Upgrade Joi #3505

merged 8 commits into from Jun 2, 2019

Conversation

chris48s
Copy link
Member

Joi is dead
long live Joi

@chris48s chris48s added the dependencies Related to dependency updates label May 29, 2019
@shields-ci
Copy link

shields-ci commented May 29, 2019 •
edited

Warnings
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for debian but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for dependabot but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for elm-package but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ctan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for f-droid but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for fedora but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gitlab but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for homebrew but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for hsts but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cran but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for itunes but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for coveralls but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jetbrains but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cookbook but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jira but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codeship but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for librariesio but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codecov but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for mastodon but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codacy but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for maven-central but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for circleci but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for maven-metadata but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cii-best-practices but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for nexus but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cdnjs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for packagecontrol but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bundlephobia but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pub but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bstats but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for reddit but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bountysource but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for shippable but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bitrise but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for sourceforge but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bitbucket but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for sourcegraph but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bit but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for spiget but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bintray but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for stackexchange but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for beerpay but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for static-badge but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for aur but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for steam but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for archlinux but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for swagger but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for apm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for twitter but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ansible but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ubuntu but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ Lots 'o changes. Skipping diff-based checks.
⚠️ This PR modified service code for wercker but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified helper functions in lib/ but not accompanying tests.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for wheelmap but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for endpoint but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 767ecf0

platan
platan previously approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@platan platan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try with version 15.0.3: https://www.npmjs.com/package/@hapi/joi?

@paulmelnikow
Copy link
Member

Hmm, don't we also need to change require('joi') to require('@hapi/joi')?

It looks like we are still installing another copy of Joi (and that's probably what's being used now). Any idea where the joi requirement is being pulled in?

For IcedFrisby Joi is a peer dependency (which definitely should be switched over to @hapi/joi). Probably that needs to happen for us to actually that in our service tests.

@chris48s
Copy link
Member Author

Right, yes of course - good point. I assumed there was some backwards-compatibility magic going on there ✨

Any idea where the joi requirement is being pulled in?

icedfrisby requires joi": "*" and then start-server-and-test (used in the end-to-end tests) transitively requires "joi": "^13.0.0", so we're going to end up with 2 copies of Joi in the tree somewhere until both of those are updated to use @hapi/joi.

@paulmelnikow
Copy link
Member

It's an optional dep in icedfrisby so that's not what's triggering it being pulled in.

jeffbski/wait-on#37 is the issue for the transitive dep of start-server-and-test.

How about we fix the optional dep in IcedFrisby to use @hapi/joi and update all our require's to do the same. That way we'll still have two copies of the dependency, but at least our code will all be using the same version.

@chris48s chris48s mentioned this pull request May 30, 2019
Merged
@chris48s
Copy link
Member Author

Having done the epic find & replace, it looks like we are also blocked on dszakallas/joi-extension-semver#2 to get this working.

@chris48s chris48s changed the title upgrade Joi WIP upgrade Joi May 30, 2019
@chris48s chris48s changed the title WIP upgrade Joi WIP: upgrade Joi May 30, 2019
@paulmelnikow paulmelnikow mentioned this pull request May 30, 2019
Merged
@paulmelnikow
Copy link
Member

I shipped icedfrisby@2.0.0 🎉 which includes this update.

@chris48s chris48s changed the title WIP: upgrade Joi Upgrade Joi [*****] Jun 1, 2019
@chris48s chris48s changed the title Upgrade Joi [*****] Upgrade Joi Jun 1, 2019
@chris48s
Copy link
Member Author

chris48s commented Jun 1, 2019

Did a full test run. Some timeouts and transient failures, but nothing related to this

paulmelnikow
paulmelnikow approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chris48s chris48s merged commit 8621fe4 into badges:master Jun 2, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

@platan platan platan left review comments

Assignees
No one assigned
Labels
dependencies Related to dependency updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chris48s @shields-ci @paulmelnikow @platan