Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit isomorphic-form-data import #6626

Merged
merged 2 commits into from Jul 27, 2021

Conversation

timbonicus
Copy link
Contributor

@timbonicus timbonicus commented Jul 27, 2021

The e2e tests are failing:

Module not found: Can't resolve 'isomorphic-form-data' in '/tmp/backstage-e2e-3c0fu9/test-app/node_modules/swagger-ui-react'

This is filed via swagger-api/swagger-ui#7436; fix for now seems to be including isomorphic-form-data explicitly in dependencies.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Tim Hansen <timbonicus@gmail.com>
@timbonicus timbonicus requested a review from a team as a code owner July 27, 2021 19:33
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2021

🦋 Changeset detected

Latest commit: bebc09f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@backstage/plugin-api-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Tim Hansen <timbonicus@gmail.com>
@benjdlambert benjdlambert merged commit e69445d into master Jul 27, 2021
@benjdlambert benjdlambert deleted the timbonicus/e2e-isomorphic-form-data branch July 27, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants