Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth backend saml clock discrepancies #6609

Conversation

stephane-mori
Copy link
Contributor

This is a pull request about SAML configuration

It allow to configure acceptedClockSkewMs option.
Closes #6608

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@stephane-mori stephane-mori requested a review from a team as a code owner July 26, 2021 13:22
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2021

🦋 Changeset detected

Latest commit: 63215cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@backstage/plugin-auth-backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stephane-mori stephane-mori force-pushed the auth-backend-saml-clock-discrepancies branch from 95b3d16 to ac231da Compare July 27, 2021 13:10
@stephane-mori
Copy link
Contributor Author

I dont understand why this fail : https://github.com/backstage/backstage/actions/runs/1071270059

@benjdlambert
Copy link
Member

Looks like a swagger dependency release broke the e2e tests however, we've fixed it in #6626 so you should be able to go ahead and rebase from master and the build pass.

stephane-mori and others added 5 commits July 28, 2021 09:37
Signed-off-by: Stéphane MORI <stephane.mori@gmail.com>
Signed-off-by: Stéphane MORI <stephane.mori@gmail.com>
Signed-off-by: Stéphane MORI <stephane.mori@gmail.com>
Signed-off-by: Stéphane MORI <stephane.mori@gmail.com>
Signed-off-by: blam <ben@blam.sh>
@benjdlambert benjdlambert force-pushed the auth-backend-saml-clock-discrepancies branch from bf8d5a7 to 63215cf Compare July 28, 2021 07:37
@benjdlambert benjdlambert merged commit ec5f615 into backstage:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure SAML auth acceptedClockSkewMs
2 participants