Fix combination usages of compileModules along with other flags.
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix that landed in e20c0e4 was not quite correct. Specifically, it did not address the scenario where you explicitly set `compileModules: false` but also set other flags that relate to modules behaviors (e.g. `disableDebugTooling` or `disableEmberModulesAPIPolyfill`). This adds a number of additional tests (which emulate "real world" usage from Embroider) and ensure they pass. Co-authored-by: Edward Faulkner <edward@eaf4.com>
This was referenced May 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix that landed in #402 was not quite correct. Specifically, it did not address the scenario where you explicitly set
compileModules: falsebut also set other flags that relate to modules behaviors (e.g.disableDebugToolingordisableEmberModulesAPIPolyfill).This adds a number of additional tests (which emulate "real world" usage from Embroider) and ensure they pass.
Also related: ember-polyfills/ember-cached-decorator-polyfill#70