Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix combination usages of compileModules along with other flags. #407

Merged
merged 1 commit into from May 18, 2021

Commits on May 18, 2021

  1. Fix combination usages of compileModules along with other flags.

    The fix that landed in e20c0e4 was not quite correct. Specifically, it
    did not address the scenario where you explicitly set `compileModules:
    false` but also set other flags that relate to modules behaviors (e.g.
    `disableDebugTooling` or `disableEmberModulesAPIPolyfill`).
    
    This adds a number of additional tests (which emulate "real world" usage
    from Embroider) and ensure they pass.
    
    Co-authored-by: Edward Faulkner <edward@eaf4.com>
    rwjblue and ef4 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    89245f9 View commit details
    Browse the repository at this point in the history