New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete "fake" source map comments from strings #9960

Merged

nicolo-ribaudo merged 1 commit into babel:master from nicolo-ribaudo:sourcemap-comment-strings

Aug 14, 2019

Commits on May 8, 2019

Do not delete "fake" source map comments from strings

Instead of using `convert-source-map`'s `removeComments` method before
parsing the file, we can first parse the file with `@babel/parser` and then
analyze the comments.
This is needed because it is not possible to reliabily detect comments in
JavaScript without fully parsing the file:
thlorenz/convert-source-map#63

nicolo-ribaudo committed May 8, 2019