New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not delete "fake" source map comments from strings #9960
Do not delete "fake" source map comments from strings #9960
Conversation
Instead of using `convert-source-map`'s `removeComments` method before parsing the file, we can first parse the file with `@babel/parser` and then analyze the comments. This is needed because it is not possible to reliabily detect comments in JavaScript without fully parsing the file: thlorenz/convert-source-map#63
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10774/ |
1 similar comment
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10774/ |
@tanhauhau @JLHwung I noticed your 👍s on this PR. Does it mean that you have reviewed it? I'm asking because you are both more involved than the "casual 👍ers" 😅 |
@nicolo-ribaudo 🤦♂️ Sometimes I thumb up for epic PRs (especially merged). But this one looks good to me. |
Commit message: