New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[decorators] Support async and generator methods #8742
Merged
nicolo-ribaudo
merged 1 commit into
babel:master
from
nicolo-ribaudo:decorators-async-methods
Sep 25, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...l-plugin-proposal-decorators/test/fixtures/transformation/async-generator-method/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
@decorator | ||
class Foo { | ||
async f1() {} | ||
|
||
*f2() {} | ||
|
||
async *f3() {} | ||
} |
8 changes: 8 additions & 0 deletions
8
...ugin-proposal-decorators/test/fixtures/transformation/async-generator-method/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"plugins": [ | ||
["proposal-decorators", { "decoratorsBeforeExport": false }], | ||
"proposal-class-properties", | ||
"syntax-async-generators", | ||
["external-helpers", { "helperVersion": "7.0.2" }] | ||
] | ||
} |
33 changes: 33 additions & 0 deletions
33
...-plugin-proposal-decorators/test/fixtures/transformation/async-generator-method/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
let Foo = babelHelpers.decorate([decorator], function (_initialize) { | ||
"use strict"; | ||
|
||
class Foo { | ||
constructor() { | ||
_initialize(this); | ||
} | ||
|
||
} | ||
|
||
return { | ||
F: Foo, | ||
d: [{ | ||
kind: "method", | ||
key: "f1", | ||
|
||
async value() {} | ||
|
||
}, { | ||
kind: "method", | ||
key: "f2", | ||
|
||
*value() {} | ||
|
||
}, { | ||
kind: "method", | ||
key: "f3", | ||
|
||
async *value() {} | ||
|
||
}] | ||
}; | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is because we don't require you do to async/generator in
t.X
? A weird bug just since we don't pass it down but not sure what we would want to do in general for itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t.functionDeclaration
accepts async/generator butt.objectMethod
doesn't.I'd love to have a function to specify the fields I want, like