[decorators] Support async and generator methods #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Sep 20, 2018
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #8737 |
| Patch: Bug Fix? | 👍 |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9146/ |
existentialism
approved these changes
Sep 24, 2018
hzoo
approved these changes
Sep 24, 2018
hzoo
reviewed
Sep 24, 2018
| function value(body, params = []) { | ||
| return t.objectMethod("method", t.identifier("value"), params, body); | ||
| function value(body, params = [], async, generator) { | ||
| const method = t.objectMethod("method", t.identifier("value"), params, body); |
There was a problem hiding this comment.
I guess this is because we don't require you do to async/generator in t.X? A weird bug just since we don't pass it down but not sure what we would want to do in general for it
There was a problem hiding this comment.
t.functionDeclaration accepts async/generator but t.objectMethod doesn't.
I'd love to have a function to specify the fields I want, like
t.objectMethod.with({
kind: "method",
key: t.identifier("value"),
params, body, async, generator
});
This was referenced Sep 29, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.