Remove nonstandard functions and fake prototype methods from babel-runtime #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
added
the
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8939/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8939/ |
existentialism
approved these changes
Aug 27, 2018
taion
reviewed
Mar 7, 2019
| Symbol: { | ||
| asyncIterator: "symbol/async-iterator", |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we removed the nonstandard stuff from the polyfill, I'm also removing it from the runtime too.
The runtime also allowed stuff like
Array.fill()as a fake replacement forArray.prototype.fillwhich is bad form mostly. We can work on improving support for prototype-based runtime functions, but we shouldn't encourage of entirely made-up function placement, if we can avoid it.Lastly, this adds support for
Symbol.asyncIteratorwhich I realized was missing.