Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill option is removed from babel-transform-runtime RC4, causing build to break #85

Closed
balcsida opened this issue Sep 9, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@balcsida
Copy link
Member

balcsida commented Sep 9, 2018

During the manual testing of #81, building the bookmark-it extension failed because Babel 7-RC4 removed polyfill option from transform-runtime (see babel/babel#8547 for more info on that).

First of all, I would like to fix this issue, it seems that simply removing this configuration option from our side is enough.
Secondly, I will open a separate Issue, so next time npm test will try to build the bookmark-it example extension, so Travis and AppVeyor has greater chance to catch these kind of issues.

@balcsida balcsida added the bug Something isn't working label Sep 9, 2018
@balcsida balcsida self-assigned this Sep 9, 2018
balcsida referenced this issue in balcsida/webextension-toolbox Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant