Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/regenerator fixtures #6113

Merged
merged 3 commits into from Aug 16, 2017
Merged

Fix/regenerator fixtures #6113

merged 3 commits into from Aug 16, 2017

Conversation

Andarist
Copy link
Member

Q                       A
Fixed Issues This should close PR #6109
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added/Pass? yes
Spec Compliancy? no
License MIT
Doc PR
Any Dependency Changes? no

Those are fixed fixtures for #6109 . When merged it should automatically close the other PR too.

@mention-bot
Copy link

@Andarist, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @hulkish to be potential reviewers.

@Andarist
Copy link
Member Author

This failing test:
babel-plugin-transform-es2015-parameters/parameters rest member expression optimisation
is not connected to this PR and Im unsure what should I do. Should a separate PR with updated fixture be filed? cc @hzoo

@existentialism
Copy link
Member

existentialism commented Aug 16, 2017 •
edited

@Andarist will land #6116 in a sec, then this should be g2g

@Andarist
Copy link
Member Author

@existentialism had to rebase it so the #6109 wont get automatically closed anymore (please close it manually), checks are passing atm though so 🎉

cc @benjamn

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 16, 2017
@hzoo hzoo merged commit 70ab2e0 into babel:7.0 Aug 16, 2017
@hzoo hzoo mentioned this pull request Aug 16, 2017
Closed
@benjamn
Copy link
Contributor

benjamn commented Aug 16, 2017

🎉

@Andarist Andarist deleted the fix/regenerator-fixtures branch August 16, 2017 16:08
@existentialism existentialism mentioned this pull request Sep 15, 2017
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andarist @mention-bot @existentialism @benjamn @hzoo