Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regenerator-transform to version 0.10.0. #6109

Closed
wants to merge 2 commits into from

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Aug 15, 2017

Q                       A
Fixed Issues none
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added/Pass? no
Spec Compliancy? no
License MIT
Doc PR no
Any Dependency Changes? yes

The most notable improvement is that Regenerator now generates code that is easier for tools like Webpack to tree-shake, thanks to work by @modosc and @Andarist: facebook/regenerator#309

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'd like to remove babel-runtime since this is the only package that still contains it as a dep

@benjamn
Copy link
Contributor Author

benjamn commented Aug 15, 2017

Circle CI is pretty hosed right now, so these tests might have to be restarted later.

@modosc
Copy link

modosc commented Aug 15, 2017

any chance of getting this backported to the 6.x branch as well? i'd be happy to make the pr

@hzoo
Copy link
Member

hzoo commented Aug 15, 2017

@modosc since got pinged multiple times about another 6.x release that I'm doing now sure 😛 . Not that we don't do backports but the more backports and releases the less focus on 7.x.

@Andarist
Copy link
Member

@hzoo aint sure how ur git flow works now, but it could be accommodate somehow to ease the pain with backports? especially when in the transition process between latest stable and development alpha/beta/candidates?

maybe adding backport labels would help with releasing the newest non breaking changes for the stable version?

@modosc
Copy link

modosc commented Aug 15, 2017

@hzoo thanks, opened #6111

@hzoo
Copy link
Member

hzoo commented Aug 15, 2017

Will need to fix the fixtures in both

@hzoo
Copy link
Member

hzoo commented Aug 16, 2017

#6113 adds the test changes

@hzoo hzoo closed this Aug 16, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants