Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regenerator #6111

Merged
merged 3 commits into from Aug 16, 2017
Merged

Update regenerator #6111

merged 3 commits into from Aug 16, 2017

Conversation

modosc
Copy link

@modosc modosc commented Aug 15, 2017

Q                       A
Fixed Issues none
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added/Pass? no
Spec Compliancy? no
License MIT
Doc PR no
Any Dependency Changes? yes

The most notable improvement is that Regenerator now generates code that is easier for tools like Webpack to tree-shake, thanks to work by @modosc and @Andarist: facebook/regenerator#309

@hzoo
Copy link
Member

hzoo commented Aug 15, 2017

fixtures need updates in both prs

@modosc
Copy link
Author

modosc commented Aug 16, 2017

fixtures updated.

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Linter failed for an unrelated reason I think:

no such file or directory, access '/home/travis/build/babel/babel/node_modules/babel-helper-wrap-function'

@hzoo hzoo merged commit 9c81c1c into babel:6.x Aug 16, 2017
@hzoo
Copy link
Member

hzoo commented Aug 16, 2017

ugh, merged to 6.x again (need to delete it since I'm releasing from master)

hzoo added a commit that referenced this pull request Aug 16, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
6.x: backport area: upstream outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants