Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another test for runtime order of template literals #6092

Merged
merged 4 commits into from
Aug 12, 2017
Merged

Add another test for runtime order of template literals #6092

merged 4 commits into from
Aug 12, 2017

Commits on Aug 12, 2017

  1. Restrict the kinds of expressions that force a .concat call split 

    This avoids creating extra .concat calls unless the result could be
potentially observably different from real template evaluation.
    Diogo Franco (Kovensky) committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    86adc6f View commit details
    Browse the repository at this point in the history

  2. Revert "Restrict the kinds of expressions that force a .concat call s… 

    …plit"

This reverts commit 86adc6f.

Signed-off-by: Diogo Franco (Kovensky) <diogomfranco@gmail.com>
    Diogo Franco (Kovensky) committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    8f6457e View commit details
    Browse the repository at this point in the history

  3. Add another test for execution order 

    More proof that it really is unsafe to merge the .concat calls if the
value is an expression that has any chance of executing impure code 😢
    Diogo Franco (Kovensky) committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    148f926 View commit details
    Browse the repository at this point in the history

  4. Run prettier on test

    Diogo Franco (Kovensky) committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    e237b9d View commit details
    Browse the repository at this point in the history