Add another test for runtime order of template literals #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating extra .concat calls unless the result could be potentially observably different from real template evaluation.
|
@Kovensky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yavorsky, @jridgewell and @existentialism to be potential reviewers. |
added 2 commits
August 12, 2017 13:50
…plit" This reverts commit 86adc6f. Signed-off-by: Diogo Franco (Kovensky) <diogomfranco@gmail.com>
More proof that it really is unsafe to merge the .concat calls if the value is an expression that has any chance of executing impure code 😢
Jessidhia
changed the title
bakkot
approved these changes
Aug 12, 2017
|
For reference, this is a followup to #5791. |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating extra .concat calls unless the result could bepotentially observably different from real template evaluation.
The idea is that even if you have multiple objects with@@toPrimitivein them, they will still be evaluated left-to-right anyway; but any arbitrary
impure code besides a
@@toPrimitiveimplementation would be ableto observe that a previous object's
@@toPrimitivewas not yet evaluated.Turns out that you don't even need fancy things such as comma operators
or function calls for the difference to be observable. Adds a test that should
pass but would've broken with my original commit.