Emit parens for await of ternary expressions #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikdesjardins, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @bjouhier to be potential reviewers. |
existentialism
added
pkg: generator
PR: Bug Fix 馃悰
loganfsmyth
approved these changes
Feb 6, 2017
|
btw @erikdesjardins I know you're probably busy with RES and other things, but would you like to be added as a collaborator on our team? We'd love to have you |
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The await expression:
await 1 ? 2 : 3is equivalent to:(await 1) ? 2 : 3so parens must be emitted for:await (1 ? 2 : 3)Bizarrely, this is not the same as yield expressions, where:
yield 1 ? 2 : 3is equivalent to:yield (1 ? 2 : 3)and not equivalent to:(yield 1) ? 2 : 3I have no idea why the spec is like this 馃槙