Emit parens for await (but not yield) of ternary expressions (#5270)

babel · Feb 6, 2017 · e9d7757 · e9d7757
1 parent 8c3392f
commit e9d7757
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 0 deletions.
diff --git a/packages/babel-generator/src/node/parentheses.js b/packages/babel-generator/src/node/parentheses.js
@@ -197,6 +197,10 @@ export function ConditionalExpression(node: Object, parent: Object): boolean {
     return true;
   }
 
+  if (t.isAwaitExpression(parent)) {
+    return true;
+  }
+
   return UnaryLike(node, parent);
 }
 

diff --git a/packages/babel-generator/test/fixtures/parentheses/await-expression/actual.js b/packages/babel-generator/test/fixtures/parentheses/await-expression/actual.js
@@ -3,6 +3,7 @@ async function asdf() {
   (await b)();
   new (await b)();
   true ? (await 1) : (await 2);
+  await (1 ? 2 : 3);
   await (await 1);
 }
 

diff --git a/packages/babel-generator/test/fixtures/parentheses/await-expression/expected.js b/packages/babel-generator/test/fixtures/parentheses/await-expression/expected.js
@@ -3,6 +3,7 @@ async function asdf() {
   (await b)();
   new (await b)();
   true ? await 1 : await 2;
+  await (1 ? 2 : 3);
   await await 1;
 }
 

diff --git a/packages/babel-generator/test/fixtures/parentheses/yield-expression/actual.js b/packages/babel-generator/test/fixtures/parentheses/yield-expression/actual.js
@@ -3,6 +3,7 @@ function* asdf() {
   (yield b)();
   new (yield b)();
   (yield 1) ? (yield 2) : (yield 3);
+  yield (1 ? 2 : 3);
   yield (yield 1);
 }
 

diff --git a/packages/babel-generator/test/fixtures/parentheses/yield-expression/expected.js b/packages/babel-generator/test/fixtures/parentheses/yield-expression/expected.js
@@ -3,6 +3,7 @@ function* asdf() {
   (yield b)();
   new (yield b)();
   (yield 1) ? yield 2 : yield 3;
+  yield 1 ? 2 : 3;
   yield yield 1;
 }