Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError with babel-register's cache #5260

Merged
merged 5 commits into from Feb 8, 2017

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Feb 3, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets #5259
License MIT
Doc PR
Dependency Changes

Follow up from #5259.

@xtuc xtuc added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Feb 3, 2017
@mention-bot
Copy link

@xtuc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sindresorhus, @jonathanong and @SimenB to be potential reviewers.

@xtuc
Copy link
Member Author

xtuc commented Feb 5, 2017

I took this opportunity to add some tests to babel-register's cache. It is quite difficult to do.

Could you tell me what do you think about this test suite. Should we modify the code to make it more testable? Because we can't cover all the cases right now.

@babel-bot
Copy link
Collaborator

Hey @xtuc! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@existentialism
Copy link
Member

Funny enough, the reason the tests fail during the coverage run is because nyc sets BABEL_DISABLE_CACHE=1 😆

@xtuc
Copy link
Member Author

xtuc commented Feb 7, 2017

Oh, you're right 👍 Thanks for pointing out this to me.

@codecov-io
Copy link

codecov-io commented Feb 7, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@283d9cb). Click here to learn what that means.

@@            Coverage Diff            @@
##             master    #5260   +/-   ##
=========================================
  Coverage          ?   89.34%           
=========================================
  Files             ?      204           
  Lines             ?     9912           
  Branches          ?     2666           
=========================================
  Hits              ?     8856           
  Misses            ?     1056           
  Partials          ?        0
Impacted Files Coverage Δ
packages/babel-register/src/cache.js 81.81% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283d9cb...5c9edd6. Read the comment docs.

@hzoo
Copy link
Member

hzoo commented Feb 8, 2017

Nice work both of you!

@hzoo hzoo merged commit fb0a91b into babel:master Feb 8, 2017
@xtuc xtuc deleted the fix-babel-register-cache branch February 8, 2017 20:31
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants