New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeError with babel-register's cache #5260
Conversation
@xtuc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sindresorhus, @jonathanong and @SimenB to be potential reviewers. |
I took this opportunity to add some tests to babel-register's cache. It is quite difficult to do. Could you tell me what do you think about this test suite. Should we modify the code to make it more testable? Because we can't cover all the cases right now. |
Hey @xtuc! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
Funny enough, the reason the tests fail during the coverage run is because |
Oh, you're right 👍 Thanks for pointing out this to me. |
Codecov Report
@@ Coverage Diff @@
## master #5260 +/- ##
=========================================
Coverage ? 89.34%
=========================================
Files ? 204
Lines ? 9912
Branches ? 2666
=========================================
Hits ? 8856
Misses ? 1056
Partials ? 0
Continue to review full report at Codecov.
|
Nice work both of you! |
Follow up from #5259.