[7.0] Default babel-register cache location to node_modules

[hzoo]

why: easier to find since it's in node_modules, easy to clear all cache for all the tools that use it.

Move register cache file location to ./node_modules/.cache/babel-register via

https://github.com/avajs/find-cache-dir

Ref previous babel-loader PR: https://github.com/babel/babel-loader/pull/301/files as well as the current file (https://github.com/babel/babel-loader/blob/e9e37029e0c5905d8846f69d9a0c348f3d49fe50/src/fs-cache.js#L170), https://github.com/babel/babel-loader/pull/318/files

---

• Comment below you are going to do this (for others to know)
• Read CONTRIBUTING.md (make sure you have yarn, and are on at least node 4)
• Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
• remember to run make build after a source code change or better just run make watch in another terminal window to auto run babel while you are developing
• Default to findCacheDir({ name: "babel-register" }) and fallback to os/home/tmp dir.
• if there are already tests setup for that package, write another test (otherwise we'll do it or help)

[shubheksha]

I'll take this one!

[shubheksha]

What about the BABEL_CACHE_PATH variable? Currently the default with the fall back being implemented as a JSON file. Will that logic be removed completely?
https://github.com/babel/babel/blob/master/packages/babel-register/src/cache.js#L6

[shubheksha]

Also, I guess I'll have to write a couple of tests for this package? I couldn't find any in it's folder. I'd appreciate any guidelines to get started.

[xtuc]

I think the cache location should still be overridable (BABEL_CACHE_PATH).

I tried to add some tests (there).

[shubheksha]

@xtuc & @hzoo, does this look right?
var FILENAME = process.env.BABEL_CACHE_PATH || findCacheDir({ name: 'babel-register' }) || os.tmpdir();

I'll wait for #5260 to land before writing tests for this patch.

[hzoo]

Yeah 👍 (dono if we really want to support BABEL_CACHE_PATH anymore but just so it's one less thing to break we could keept it).

[xtuc]

@shubheksha The PR has been merged. Don't hesitate to tell me if anything is wrong with the tests.

[aaronang]

What is the current status of this issue?

[pwmckenna]

@shubheksha don't mean to step on your toes if you're still working on this. feel free to just close this pr, but its been a while and seemed simple enough that I thought I'd just make the PR. Not sure how this fits in with the long term cache plans, but would be a nice intermediate change.

[xtuc]

The config caching has a bit changed. @loganfsmyth worked on it.

See #5608 for ex.