Don't transpile ES7 symbol properties #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.22% (diff: 100%)@@ master #5195 diff @@
==========================================
Files 203 203
Lines 9838 9838
Methods 1071 1071
Messages 0 0
Branches 2624 2624
==========================================
Hits 8778 8778
Misses 1060 1060
Partials 0 0
|
|
I could add a test case asserting that the runtime transform does not pull in the |
This was referenced Jan 25, 2017
|
Any updates here? |
xtuc
added
the
PR: Bug Fix 🐛
|
Please merge, the React ecosystem needs it :-/ |
hzoo
approved these changes
Feb 6, 2017
|
existentialism
approved these changes
Feb 7, 2017
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
This was referenced Mar 7, 2019
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Mar 10, 2019
This is a repeat of #5195 to work around the same upstream issue.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending zloirock/core-js#267, this works around the root cause of #4783 in zloirock/core-js#262 by pulling in the full
Symbolpolyfill instead of just theSymbol.asyncIteratorpolyfill.Generally in the context of using the runtime transform, it'd be almost impossible to avoid pulling in the
Symbolpolyfill when using async iterators anyway, so in practice this is unlikely to make things worse.More to the point, as the
asyncIteratorhelper and the core-js imports are set up, async iteration won't work without pulling in the fullSymbolpolyfill anyway.It's not clear to me how to add a test case for this, or whether it'd be necessary to do so here.