Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Accessor alias description #14571

Merged
merged 2 commits into from May 24, 2022
Merged

add Accessor alias description #14571

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c439e05
add Accessor alias description
JLHwung May 20, 2022
a1531ae
Update packages/babel-types/scripts/generators/docs.js
JLHwung May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/babel-types/scripts/generators/docs.js
View file
Open in desktop
Expand Up @@ -176,6 +176,7 @@ function generateMapAliasToNodeTypes() {
return result;
}
const aliasDescriptions = {
Accessor: "A cover of ClassAccessorProperty.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Accessor currently only covers ClassAccessorProperty. I believe it used to cover ClassAccessorProperty and ClassPrivateAccessorProperty but later we merged these two. We may consider remove it in Babel 8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should remove it in Babel 8.

JLHwung marked this conversation as resolved.
Show resolved Hide resolved
Binary:
"A cover of BinaryExpression and LogicalExpression, which share the same AST shape.",
Block: "Deprecated. Will be removed in Babel 8.",
Expand Down