Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Accessor alias description #14571

Merged
merged 2 commits into from May 24, 2022
Merged

add Accessor alias description #14571

merged 2 commits into from May 24, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 20, 2022 •
edited by gitpod-io bot

Q                       A
Documentation PR Link babel/website#2648
License MIT

JLHwung
JLHwung commented May 20, 2022
View reviewed changes
packages/babel-types/scripts/generators/docs.js Outdated
@@ -176,6 +176,7 @@ function generateMapAliasToNodeTypes() {
return result;
}
const aliasDescriptions = {
Accessor: "A cover of ClassAccessorProperty.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Accessor currently only covers ClassAccessorProperty. I believe it used to cover ClassAccessorProperty and ClassPrivateAccessorProperty but later we merged these two. We may consider remove it in Babel 8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should remove it in Babel 8.

@babel-bot
Copy link
Collaborator

babel-bot commented May 20, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52001/

@existentialism existentialism added pkg: types PR: Docs 📝 A type of pull request used for our changelog categories labels May 24, 2022
@JLHwung JLHwung merged commit dd42951 into babel:main May 24, 2022
@JLHwung JLHwung deleted the update-types-docs branch May 24, 2022 14:51
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @existentialism @nicolo-ribaudo