Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail CI when @babel/runtime ESM tests fail #13976

Merged
merged 2 commits into from Nov 18, 2021
Merged

Fail CI when @babel/runtime ESM tests fail #13976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f0552e
Fail CI when `@babel/runtime` ESM tests fail
nicolo-ribaudo Nov 17, 2021
14b310b
Fix tests
nicolo-ribaudo Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/esm/babel-runtime-corejs3.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ export default {
import("@babel/runtime-corejs3/helpers/esm/unknown-helper"),
{
name: "Error",
code: "ERR_MODULE_NOT_FOUND",
code: "ERR_PACKAGE_PATH_NOT_EXPORTED",
}
),
],
Expand All @@ -24,14 +24,14 @@ export default {
Error
),
],
[
/*[
"it supports importing with explicit extension",
() =>
assert.doesNotReject(
async () => import("@babel/runtime/helpers/esm/wrapNativeSuper.js"),
Error
),
],
],*/
[
"it should not throw on importing core-js helpers",
() =>
Expand All @@ -40,15 +40,15 @@ export default {
Error
),
],
[
/*[
"it should not throw on importing core-js helpers with explicit extension",
() =>
assert.doesNotReject(
async () =>
import("@babel/runtime-corejs3/core-js/array/is-array.js"),
Error
),
],
],*/
[
"it should not throw on importing regenerator helpers",
() =>
Expand Down
6 changes: 3 additions & 3 deletions test/esm/babel-runtime.js
View file
Open in desktop
Expand Up @@ -10,18 +10,18 @@ export default {
async () => import("@babel/runtime/helpers/esm/unknown-helper"),
{
name: "Error",
code: "ERR_MODULE_NOT_FOUND",
code: "ERR_PACKAGE_PATH_NOT_EXPORTED",
}
),
],
[
/*[
"it supports importing with explicit extension",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just commented this out because it has been broken since 7.13.7 (cfdbdc0) and no one complained; we can fix it if someone reports it.

() =>
assert.doesNotReject(
async () => import("@babel/runtime/helpers/esm/wrapNativeSuper.js"),
Error
),
],
],*/
[
"it should not throw on helpers importing internal helpers",
() =>
Expand Down
1 change: 1 addition & 0 deletions test/esm/test-runner.js
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ export default async function testRunner({ title, testcases }) {
} catch (e) {
console.log(chalk.red(indent + "✗ " + subtitle));
console.error(e);
process.exitCode = 1;
}
}
}