Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail CI when @babel/runtime ESM tests fail #13976

Merged
merged 2 commits into from Nov 18, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 17, 2021

Q                       A
License MIT

These tests only run in the CI / Test on Node.js Latest job, but if they fail the job was still marked as green.

@nicolo-ribaudo
Copy link
Member Author

This is correctly reported as failing now: https://github.com/babel/babel/runs/4240940764?check_suite_focus=true

}
),
],
[
/*[
"it supports importing with explicit extension",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just commented this out because it has been broken since 7.13.7 (cfdbdc0) and no one complained; we can fix it if someone reports it.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 17, 2021
@nicolo-ribaudo
Copy link
Member Author

Merging with a single ✔️ because this doesn't affect public code and only changes how a few tests are reported from "less strict" to "more strict".

@nicolo-ribaudo nicolo-ribaudo merged commit 90c659b into babel:main Nov 18, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the runtime-fail-ci branch November 18, 2021 23:22
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants