Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reorganize benchmarks #13606

Merged
merged 2 commits into from Jul 28, 2021
Merged

chore: reorganize benchmarks #13606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b0d8b
chore: reorganize benchmarks
JLHwung Jul 27, 2021
a6275b2
add back @babel/parser dev dependency of @babel/generator
JLHwung Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...benchmark/many-empty-statements/bench.mjs → ...generator/many-empty-statements/bench.mjs
View file
Open in desktop
@@ -1,8 +1,8 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/generator";
import current from "../../lib/index.js";
import current from "@babel/generator";
import parser from "@babel/parser";
import { report } from "../util.mjs";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
4 changes: 2 additions & 2 deletions ...r/benchmark/many-identifiers/1-length.mjs → ...l-generator/many-identifiers/1-length.mjs
View file
Open in desktop
@@ -1,8 +1,8 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/generator";
import current from "../../lib/index.js";
import current from "@babel/generator";
import parser from "@babel/parser";
import { report } from "../util.mjs";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
4 changes: 2 additions & 2 deletions .../benchmark/many-identifiers/25-length.mjs → ...-generator/many-identifiers/25-length.mjs
View file
Open in desktop
@@ -1,8 +1,8 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/generator";
import current from "../../lib/index.js";
import current from "@babel/generator";
import parser from "@babel/parser";
import { report } from "../util.mjs";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
0 ...erator/benchmark/real-case/jquery-3.6.txt → .../babel-generator/real-case/jquery-3.6.txt
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...-generator/benchmark/real-case/jquery.mjs → ...mark/babel-generator/real-case/jquery.mjs
View file
Open in desktop
@@ -1,8 +1,8 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/generator";
import current from "../../lib/index.js";
import current from "@babel/generator";
import parser from "@babel/parser";
import { report } from "../util.mjs";
import { report } from "../../util.mjs";
import { readFileSync } from "fs";

const suite = new Benchmark.Suite();
Expand Down
0 ...identifier/benchmark/identifier.bench.mjs → ...validator-identifier/identifier.bench.mjs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...fier/benchmark/isIdentifierChar.bench.mjs → ...tor-identifier/isIdentifierChar.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel/helper-validator-identifier-baseline";
import current from "../lib/index.js";
import { report } from "./util.mjs";
import baseline from "@babel-baseline/helper-validator-identifier";
import current from "@babel/helper-validator-identifier";
import { report } from "../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
6 changes: 3 additions & 3 deletions ...fier/benchmark/isIdentifierName.bench.mjs → ...tor-identifier/isIdentifierName.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel/helper-validator-identifier-baseline";
import current from "../lib/index.js";
import { report } from "./util.mjs";
import baseline from "@babel-baseline/helper-validator-identifier";
import current from "@babel/helper-validator-identifier";
import { report } from "../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
6 changes: 3 additions & 3 deletions ...ier/benchmark/isIdentifierStart.bench.mjs → ...or-identifier/isIdentifierStart.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel/helper-validator-identifier-baseline";
import current from "../lib/index.js";
import { report } from "./util.mjs";
import baseline from "@babel-baseline/helper-validator-identifier";
import current from "@babel/helper-validator-identifier";
import { report } from "../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
6 changes: 3 additions & 3 deletions ...-identifier/benchmark/isKeyword.bench.mjs → ...-validator-identifier/isKeyword.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel/helper-validator-identifier-baseline";
import current from "../lib/index.js";
import { report } from "./util.mjs";
import baseline from "@babel-baseline/helper-validator-identifier";
import current from "@babel/helper-validator-identifier";
import { report } from "../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
6 changes: 3 additions & 3 deletions ...chmark/isStrictBindReservedWord.bench.mjs → ...tifier/isStrictBindReservedWord.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel/helper-validator-identifier-baseline";
import current from "../lib/index.js";
import { report } from "./util.mjs";
import baseline from "@babel-baseline/helper-validator-identifier";
import current from "@babel/helper-validator-identifier";
import { report } from "../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
4 changes: 2 additions & 2 deletions ...l-parser/benchmark/large-regexp/bench.mjs → ...hmark/babel-parser/large-regexp/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions .../many-arrow-function-flow-types/bench.mjs → .../many-arrow-function-flow-types/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...ser/benchmark/many-async-arrows/bench.mjs → .../babel-parser/many-async-arrows/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...ass-private-properties/1-length.bench.mjs → ...ass-private-properties/1-length.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
// All codepoints in [0x4e00, 0x9ffc] are valid identifier name per Unicode 13
Expand Down
4 changes: 2 additions & 2 deletions ...-statements/attachComment-false.bench.mjs → ...-statements/attachComment-false.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();

Expand Down
4 changes: 2 additions & 2 deletions ...hmark/many-identifiers/1-length.bench.mjs → ...arser/many-identifiers/1-length.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...mark/many-identifiers/11-length.bench.mjs → ...rser/many-identifiers/11-length.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "../../lib/index-main.js";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...hmark/many-identifiers/2-length.bench.mjs → ...arser/many-identifiers/2-length.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...rser/benchmark/many-identifiers/await.mjs → ...k/babel-parser/many-identifiers/await.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "../../lib/index-main.js";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...mark/many-inner-comments-nested/bench.mjs → ...rser/many-inner-comments-nested/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...r/benchmark/many-inner-comments/bench.mjs → ...abel-parser/many-inner-comments/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...rk/many-leading-comments-nested/bench.mjs → ...er/many-leading-comments-nested/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...benchmark/many-leading-comments/bench.mjs → ...el-parser/many-leading-comments/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions .../many-leading-trailing-comments/bench.mjs → .../many-leading-trailing-comments/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...ations-within-block/10-length-binding.mjs → ...ations-within-block/10-length-binding.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...any-let-declarations/1-length-binding.mjs → ...any-let-declarations/1-length-binding.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
// All codepoints in [0x4e00, 0x9ffc] are valid identifier name per Unicode 13
Expand Down
4 changes: 2 additions & 2 deletions ...mark/many-named-export/1-length.bench.mjs → ...rser/many-named-export/1-length.bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
// All codepoints in [0x4e00, 0x9ffc] are valid identifier name per Unicode 13
Expand Down
4 changes: 2 additions & 2 deletions ...ark/many-small-all-flags-regexp/bench.mjs → ...ser/many-small-all-flags-regexp/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "../../lib/index-v2.js";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...k/many-trailing-comments-nested/bench.mjs → ...r/many-trailing-comments-nested/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
4 changes: 2 additions & 2 deletions ...enchmark/many-trailing-comments/bench.mjs → ...l-parser/many-trailing-comments/bench.mjs
View file
Open in desktop
@@ -1,7 +1,7 @@
import Benchmark from "benchmark";
import baseline from "@babel-baseline/parser";
import current from "../../lib/index.js";
import { report } from "../util.mjs";
import current from "@babel/parser";
import { report } from "../../util.mjs";

const suite = new Benchmark.Suite();
function createInput(length) {
Expand Down
14 changes: 14 additions & 0 deletions benchmark/package.json
View file
Open in desktop
@@ -0,0 +1,14 @@
{
"name": "@babel/benchmark",
"private": true,
"type": "module",
"devDependencies": {
"@babel-baseline/generator": "npm:@babel/generator@7.14.5",
"@babel-baseline/helper-validator-identifier": "npm:@babel/helper-validator-identifier@7.10.4",
"@babel-baseline/parser": "npm:@babel/parser@7.14.5",
"@babel/generator": "workspace:*",
"@babel/helper-validator-identifier": "workspace:*",
"@babel/parser": "workspace:*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can compare performances between any versions of babel packages by revising this package.json.

Copy link

@KFlash KFlash Jul 27, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the perf diff between Rome and ESbuild vs Babel? Equal in performance?

"benchmark": "^2.1.4"
}
}
0 packages/babel-generator/benchmark/util.mjs → benchmark/util.mjs
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -75,7 +75,8 @@
"eslint/*",
"packages/*",
"test/esm",
"test/runtime-integration/*"
"test/runtime-integration/*",
"benchmark"
],
"resolutions": {
"browserslist": "npm:4.16.6",
Expand Down
2 changes: 0 additions & 2 deletions packages/babel-generator/package.json
View file
Open in desktop
Expand Up @@ -24,12 +24,10 @@
"source-map": "^0.5.0"
},
"devDependencies": {
"@babel-baseline/generator": "npm:@babel/generator@7.14.5",
"@babel/helper-fixtures": "workspace:*",
"@babel/parser": "workspace:*",
"@types/jsesc": "^2.5.0",
"@types/source-map": "^0.5.0",
"benchmark": "^2.1.4",
"charcodes": "^0.2.0"
},
"engines": {
Expand Down
1 change: 0 additions & 1 deletion packages/babel-helper-validator-identifier/.npmignore
View file
Open in desktop
@@ -1,4 +1,3 @@
benchmark
src
test
*.log
17 changes: 0 additions & 17 deletions packages/babel-helper-validator-identifier/benchmark/util.mjs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/babel-helper-validator-identifier/package.json
View file
Open in desktop
Expand Up @@ -14,9 +14,7 @@
"main": "./lib/index.js",
"exports": "./lib/index.js",
"devDependencies": {
"@babel/helper-validator-identifier-baseline": "npm:@babel/helper-validator-identifier@7.10.4",
"@unicode/unicode-13.0.0": "^1.0.6",
"benchmark": "^2.1.4",
"charcodes": "^0.2.0"
},
"engines": {
Expand Down
17 changes: 0 additions & 17 deletions packages/babel-parser/benchmark/util.mjs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/babel-parser/package.json
View file
Open in desktop
Expand Up @@ -33,11 +33,9 @@
"node": ">=6.0.0"
},
"devDependencies": {
"@babel-baseline/parser": "npm:@babel/parser@^7.14.5",
"@babel/code-frame": "workspace:*",
"@babel/helper-fixtures": "workspace:*",
"@babel/helper-validator-identifier": "workspace:*",
"benchmark": "^2.1.4",
"charcodes": "^0.2.0"
},
"bin": "./bin/babel-parser.js"
Expand Down