Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorganize benchmarks #13606

Merged
merged 2 commits into from Jul 28, 2021
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 27, 2021

Q                       A
License MIT

The benchmark files scattered in babel-generator, babel-helper-validator-identifier and babel-parser are now moved to a top level /benchmark folder. They now share the same /util.mjs benchmark setup and we don't have to hardcode package index.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 27, 2021
"@babel-baseline/parser": "npm:@babel/parser@7.14.5",
"@babel/generator": "workspace:*",
"@babel/helper-validator-identifier": "workspace:*",
"@babel/parser": "workspace:*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can compare performances between any versions of babel packages by revising this package.json.

Copy link

@KFlash KFlash Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the perf diff between Rome and ESbuild vs Babel? Equal in performance?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6275b2:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 27, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47585/

Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any report tool that runs benchmarks along with tests on the CI?

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 27, 2021

Do we have any report tool that runs benchmarks along with tests on the CI?

Not yet. After we centralize the benchmark files, we can come up with a benchmark bot that plots benchmark alongside versions so we can catch performance regressions from new releases.

@JLHwung JLHwung merged commit e4de256 into babel:main Jul 28, 2021
@JLHwung JLHwung deleted the reorganize-benchmarks branch July 28, 2021 11:10
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants