New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganize benchmarks #13606
chore: reorganize benchmarks #13606
Conversation
8bb7892
to
06b0d8b
Compare
"@babel-baseline/parser": "npm:@babel/parser@7.14.5", | ||
"@babel/generator": "workspace:*", | ||
"@babel/helper-validator-identifier": "workspace:*", | ||
"@babel/parser": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we can compare performances between any versions of babel packages by revising this package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the perf diff between Rome and ESbuild vs Babel? Equal in performance?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6275b2:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47585/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any report tool that runs benchmarks along with tests on the CI?
Not yet. After we centralize the benchmark files, we can come up with a benchmark bot that plots benchmark alongside versions so we can catch performance regressions from new releases. |
The benchmark files scattered in
babel-generator
,babel-helper-validator-identifier
andbabel-parser
are now moved to a top level/benchmark
folder. They now share the same/util.mjs
benchmark setup and we don't have to hardcode package index.