New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for override keyword in TS #13110
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45039/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6638c8c:
|
"readonly", | ||
"declare", | ||
"override", | ||
]); | ||
|
||
const idx = this.tsTryParseIndexSignature(member); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a new test case?
class C extends class {} {
override [key: string]: string;
}
TS Nightly will throw
'override' modifier cannot appear on an index signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to close this in favor of #13097, which handles this case.
Closing in favor of #13097. |
For reference,
TS blog post:
https://devblogs.microsoft.com/typescript/announcing-typescript-4-3-beta/#override-and-the-noimplicitoverride-flag
TS PR: microsoft/TypeScript@6014a3a