babel-parser(ts): Add new plugin option dts: boolean
#13113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
added
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45120/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98f5c6a:
|
fedeci
reviewed
Apr 7, 2021
| } | ||
|
|
||
| parse() { | ||
| if (this.shouldParseAsDts()) { |
There was a problem hiding this comment.
Doing so all files would be parsed as declaration though, maybe we should check the filename also?
There was a problem hiding this comment.
The parser ignores filenames (e.g. it doesn't check if a file has a .ts extension). Only files for which the dts: true option is enabled will be parsed as declaration, and it's up to the @babel/parser consumer to decide when to enable it.
nicolo-ribaudo
approved these changes
Apr 8, 2021
fedeci
approved these changes
Apr 8, 2021
JLHwung
approved these changes
Apr 8, 2021
nicolo-ribaudo
added
the
PR: Ready to be Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use
checkCommaAfterRestmethod that is implemented in #13101 so this branch is based onmain, notfeat-7.14.0/parser-updates.this.state.isDeclareContext=>this.state.isAmbientContext.dts: boolean.